CommentFieldAccessTest.php

Same filename in other branches
  1. 9 core/modules/comment/tests/src/Kernel/CommentFieldAccessTest.php
  2. 8.9.x core/modules/comment/tests/src/Kernel/CommentFieldAccessTest.php
  3. 10 core/modules/comment/tests/src/Kernel/CommentFieldAccessTest.php

Namespace

Drupal\Tests\comment\Kernel

File

core/modules/comment/tests/src/Kernel/CommentFieldAccessTest.php

View source
<?php

declare (strict_types=1);
namespace Drupal\Tests\comment\Kernel;

use Drupal\comment\CommentInterface;
use Drupal\comment\Entity\Comment;
use Drupal\comment\Entity\CommentType;
use Drupal\comment\Plugin\Field\FieldType\CommentItemInterface;
use Drupal\comment\Tests\CommentTestTrait;
use Drupal\Core\Session\AnonymousUserSession;
use Drupal\entity_test\Entity\EntityTest;
use Drupal\field\Entity\FieldConfig;
use Drupal\KernelTests\Core\Entity\EntityKernelTestBase;
use Drupal\Tests\Traits\Core\GeneratePermutationsTrait;
use Drupal\user\Entity\Role;
use Drupal\user\RoleInterface;

/**
 * Tests comment field level access.
 *
 * @group comment
 * @group Access
 */
class CommentFieldAccessTest extends EntityKernelTestBase {
    use CommentTestTrait;
    use GeneratePermutationsTrait;
    
    /**
     * {@inheritdoc}
     */
    protected static $modules = [
        'comment',
        'entity_test',
        'user',
    ];
    
    /**
     * Fields that only users with administer comments permissions can change.
     *
     * @var array
     */
    protected $administrativeFields = [
        'uid',
        'status',
        'created',
    ];
    
    /**
     * These fields are automatically managed and can not be changed by any user.
     *
     * @var array
     */
    protected $readOnlyFields = [
        'changed',
        'hostname',
        'cid',
        'thread',
    ];
    
    /**
     * These fields can be edited on create only.
     *
     * @var array
     */
    protected $createOnlyFields = [
        'uuid',
        'pid',
        'comment_type',
        'entity_id',
        'entity_type',
        'field_name',
    ];
    
    /**
     * These fields can only be edited by the admin or anonymous users if allowed.
     *
     * @var array
     */
    protected $contactFields = [
        'name',
        'mail',
        'homepage',
    ];
    
    /**
     * {@inheritdoc}
     */
    protected function setUp() : void {
        parent::setUp();
        $this->installConfig([
            'user',
            'comment',
        ]);
        $this->installSchema('comment', [
            'comment_entity_statistics',
        ]);
    }
    
    /**
     * Tests permissions on comment fields.
     */
    public function testAccessToAdministrativeFields() : void {
        // Create a comment type.
        $comment_type = CommentType::create([
            'id' => 'comment',
            'label' => 'Default comments',
            'description' => 'Default comment field',
            'target_entity_type_id' => 'entity_test',
        ]);
        $comment_type->save();
        // An administrator user. No user exists yet, ensure that the first user
        // does not have UID 1.
        $comment_admin_user = $this->createUser([
            'administer comments',
            'access comments',
        ], 'admin', FALSE, [
            'uid' => 2,
        ]);
        // Two comment enabled users, one with edit access.
        $comment_enabled_user = $this->createUser([
            'post comments',
            'skip comment approval',
            'edit own comments',
            'access comments',
        ], 'enabled');
        $comment_no_edit_user = $this->createUser([
            'post comments',
            'skip comment approval',
            'access comments',
        ], 'no edit');
        // An unprivileged user.
        $comment_disabled_user = $this->createUser([
            'access content',
        ], 'disabled');
        $role = Role::load(RoleInterface::ANONYMOUS_ID);
        $role->grantPermission('post comments')
            ->save();
        $anonymous_user = new AnonymousUserSession();
        // Add two fields.
        $this->addDefaultCommentField('entity_test', 'entity_test', 'comment');
        $this->addDefaultCommentField('entity_test', 'entity_test', 'comment_other');
        // Create a comment against a test entity.
        $host = EntityTest::create();
        $host->save();
        $host2 = EntityTest::create();
        $host2->comment->status = CommentItemInterface::CLOSED;
        $host2->comment_other->status = CommentItemInterface::CLOSED;
        $host2->save();
        // Change the second field's anonymous contact setting.
        $instance = FieldConfig::loadByName('entity_test', 'entity_test', 'comment_other');
        // Default is 'May not contact', for this field - they may contact.
        $instance->setSetting('anonymous', CommentInterface::ANONYMOUS_MAY_CONTACT);
        $instance->save();
        // Create three "Comments". One is owned by our edit-enabled user.
        $comment1 = Comment::create([
            'entity_type' => 'entity_test',
            'name' => 'Tony',
            'hostname' => 'magic.example.com',
            'mail' => 'tonythemagicalpony@example.com',
            'subject' => 'Bruce the Mesopotamian moose',
            'entity_id' => $host->id(),
            'comment_type' => 'comment',
            'field_name' => 'comment',
            'pid' => 0,
            'uid' => 0,
            'status' => 1,
        ]);
        $comment1->save();
        $comment2 = Comment::create([
            'entity_type' => 'entity_test',
            'hostname' => 'magic.example.com',
            'subject' => 'Brian the messed up lion',
            'entity_id' => $host->id(),
            'comment_type' => 'comment',
            'field_name' => 'comment',
            'status' => 1,
            'pid' => 0,
            'uid' => $comment_enabled_user->id(),
        ]);
        $comment2->save();
        $comment3 = Comment::create([
            'entity_type' => 'entity_test',
            'hostname' => 'magic.example.com',
            // Unpublished.
'status' => 0,
            'subject' => 'Gail the minke whale',
            'entity_id' => $host->id(),
            'comment_type' => 'comment',
            'field_name' => 'comment_other',
            'pid' => $comment2->id(),
            'uid' => $comment_no_edit_user->id(),
        ]);
        $comment3->save();
        // Note we intentionally don't save this comment so it remains 'new'.
        $comment4 = Comment::create([
            'entity_type' => 'entity_test',
            'hostname' => 'magic.example.com',
            // Unpublished.
'status' => 0,
            'subject' => 'Daniel the Cocker-Spaniel',
            'entity_id' => $host->id(),
            'comment_type' => 'comment',
            'field_name' => 'comment_other',
            'pid' => 0,
            'uid' => $anonymous_user->id(),
        ]);
        // Note we intentionally don't save this comment so it remains 'new'.
        $comment5 = Comment::create([
            'entity_type' => 'entity_test',
            'hostname' => 'magic.example.com',
            // Unpublished.
'status' => 0,
            'subject' => 'Wally the Border Collie',
            // This one is closed for comments.
'entity_id' => $host2->id(),
            'comment_type' => 'comment',
            'field_name' => 'comment_other',
            'pid' => 0,
            'uid' => $anonymous_user->id(),
        ]);
        // Generate permutations.
        $combinations = [
            'comment' => [
                $comment1,
                $comment2,
                $comment3,
                $comment4,
                $comment5,
            ],
            'user' => [
                $comment_admin_user,
                $comment_enabled_user,
                $comment_no_edit_user,
                $comment_disabled_user,
                $anonymous_user,
            ],
        ];
        $permutations = $this->generatePermutations($combinations);
        // Check access to administrative fields.
        foreach ($this->administrativeFields as $field) {
            foreach ($permutations as $set) {
                $may_view = $set['comment']->{$field}
                    ->access('view', $set['user']);
                $may_update = $set['comment']->{$field}
                    ->access('edit', $set['user']);
                $account_name = $set['user']->getAccountName();
                $comment_subject = $set['comment']->getSubject();
                $this->assertTrue($may_view, "User {$account_name} can view field {$field} on comment {$comment_subject}");
                $this->assertEquals($may_update, $set['user']->hasPermission('administer comments'), "User {$account_name}" . ($may_update ? 'can' : 'cannot') . "update field {$field} on comment {$comment_subject}");
            }
        }
        // Check access to normal field.
        foreach ($permutations as $set) {
            $may_update = $set['comment']->access('update', $set['user']) && $set['comment']->subject
                ->access('edit', $set['user']);
            $this->assertEquals($may_update, $set['user']->hasPermission('administer comments') || $set['user']->hasPermission('edit own comments') && $set['user']->id() == $set['comment']->getOwnerId(), sprintf('User %s %s update field subject on comment %s', $set['user']->getAccountName(), $may_update ? 'can' : 'cannot', $set['comment']->getSubject()));
        }
        // Check read-only fields.
        foreach ($this->readOnlyFields as $field) {
            // Check view operation.
            foreach ($permutations as $set) {
                $may_view = $set['comment']->{$field}
                    ->access('view', $set['user']);
                $may_update = $set['comment']->{$field}
                    ->access('edit', $set['user']);
                // Nobody has access to view the hostname field.
                if ($field === 'hostname') {
                    $view_access = FALSE;
                    $state = 'cannot';
                }
                else {
                    $view_access = TRUE;
                    $state = 'can';
                }
                $this->assertEquals($may_view, $view_access, sprintf('User %s %s view field %s on comment %s', $set['user']->getAccountName(), $state, $field, $set['comment']->getSubject()));
                $this->assertFalse($may_update, sprintf('User %s %s update field %s on comment %s', $set['user']->getAccountName(), $may_update ? 'can' : 'cannot', $field, $set['comment']->getSubject()));
            }
        }
        // Check create-only fields.
        foreach ($this->createOnlyFields as $field) {
            // Check view operation.
            foreach ($permutations as $set) {
                $may_view = $set['comment']->{$field}
                    ->access('view', $set['user']);
                $may_update = $set['comment']->{$field}
                    ->access('edit', $set['user']);
                $this->assertTrue($may_view, sprintf('User %s can view field %s on comment %s', $set['user']->getAccountName(), $field, $set['comment']->getSubject()));
                $expected = $set['user']->hasPermission('post comments') && $set['comment']->isNew() && (int) $set['comment']->getCommentedEntity()
                    ->get($set['comment']->getFieldName())->status !== CommentItemInterface::CLOSED;
                $this->assertEquals($expected, $may_update, sprintf('User %s %s update field %s on comment %s', $set['user']->getAccountName(), $expected ? 'can' : 'cannot', $field, $set['comment']->getSubject()));
            }
        }
        // Check contact fields.
        foreach ($this->contactFields as $field) {
            // Check view operation.
            foreach ($permutations as $set) {
                $may_update = $set['comment']->{$field}
                    ->access('edit', $set['user']);
                // To edit the 'mail' or 'name' field, either the user has the
                // "administer comments" permissions or the user is anonymous and
                // adding a new comment using a field that allows contact details.
                $this->assertEquals($may_update, $set['user']->hasPermission('administer comments') || $set['user']->isAnonymous() && $set['comment']->isNew() && $set['user']->hasPermission('post comments') && $set['comment']->getFieldName() == 'comment_other', sprintf('User %s %s update field %s on comment %s', $set['user']->getAccountName(), $may_update ? 'can' : 'cannot', $field, $set['comment']->getSubject()));
            }
        }
        foreach ($permutations as $set) {
            // Check no view-access to mail field for other than admin.
            $may_view = $set['comment']->mail
                ->access('view', $set['user']);
            $this->assertEquals($may_view, $set['user']->hasPermission('administer comments'));
        }
    }

}

Classes

Title Deprecated Summary
CommentFieldAccessTest Tests comment field level access.

Buggy or inaccurate documentation? Please file an issue. Need support? Need help programming? Connect with the Drupal community.